[RAC][Observability] Prevent unneeded re-renders of tgrid on opening alert flyout #108781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 16, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2021
#108805) Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The selected flyout alert prop was unnecessarily causing the leadingControlColumns property of tgrid to change, and thus cause the entire EuiDataGrid to re-render each time an alert was selected or deselected. This pr rearranges the component tree so that no longer happens, compare the scroll position of the before/after gifs below as an example.
Before:
After: